Skip to content

Fix an annoying flaky test #40000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

Fix an annoying flaky test #40000

merged 1 commit into from
Aug 8, 2025

Conversation

@zucchini-nlp
Copy link
Member

@zucchini-nlp zucchini-nlp commented Aug 7, 2025

What does this PR do?

As per title, trying to download the image from picsum times out if we run the test many times, so I moved the image to HF hub. AFAIK we can make many subsequent requests to hub downloads when testing

@zucchini-nlp zucchini-nlp requested a review from ydshieh August 7, 2025 14:18
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 7, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@wirthual wirthual mentioned this pull request Aug 7, 2025
Closed
1 task
vasqu
vasqu approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seeing this in #40002 🙏

@fancellu fancellu mentioned this pull request Aug 7, 2025
Merged
8 tasks
@ydshieh
Copy link
Collaborator

ydshieh commented Aug 7, 2025

AFAIK we can make many subsequent requests to hub downloads when testing

this is only valid if we are using HF's related methods I believe (something similar to from_pretrained).

When it is in user prompt, do you know what methods are used to download images? (pure python request ..?)

ydshieh
ydshieh approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just have a question but we can check later. Thanks

@zucchini-nlp
Copy link
Member Author

zucchini-nlp commented Aug 7, 2025

Ah, then I am not sure if this helps with issues because of too many requests. The chat template script uses simple requests to download the file

@zucchini-nlp
Copy link
Member Author

zucchini-nlp commented Aug 8, 2025

Oke, let's merge and see if it becomes less flaky

@zucchini-nlp zucchini-nlp merged commit 2469cce into huggingface:main Aug 8, 2025
15 checks passed
@gante
Copy link
Contributor

gante commented Aug 12, 2025

PR #40000 😱

@ydshieh
Copy link
Collaborator

ydshieh commented Aug 12, 2025

Congratulation! You should tweet this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ydshieh ydshieh ydshieh approved these changes

@vasqu vasqu vasqu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zucchini-nlp @HuggingFaceDocBuilderDev @ydshieh @gante @vasqu